Skip to content

Add Molecule tests covering common NGINX configurations #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Apr 15, 2024

Proposed changes

The current Molecule tests dedicated to NGINX configurations are limited to testing all NGINX Open Source and NGINX Plus directives. It works, but it is very unhelpful in helping users figure out how to use this role. By adding more tests covering specific NGINX use cases, we can point users to the working playbooks as a guide when implementing this role in their workflows. This PR includes new tests for configuring NGINX as a:

  • Web server
  • Reverse Proxy
  • Configure the NGINX stub status metrics
  • Configure the NGINX Plus API and live metrics dashboard

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document.
  • I have added Molecule tests that prove my fix is effective or that my feature works.
  • I have checked that any relevant Molecule tests pass after adding my changes.
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md).

@github-actions github-actions bot added the tests Improvements to tests label Apr 15, 2024
@alessfg alessfg self-assigned this Apr 15, 2024
@alessfg alessfg added this to the 0.7.2 milestone Apr 15, 2024
@alessfg alessfg merged commit c390971 into main Apr 15, 2024
12 checks passed
@alessfg alessfg deleted the split-tests branch April 15, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant