-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allocators from ntirpc_pkg_params #163
base: next
Are you sure you want to change the base?
Conversation
Directly using malloc and friends should be better than having our own functions to trace memory allocations using mtrace/muntrace etc. Changed minor version to 8.
I could keep the structure same and just don't use the passed in allocator/free functions, but I thought this is cleaner. I am assuming that we need [minor]version change here. |
This needs discussion with Matt, who's traveling this week. |
the purpose of this wasn't to use tracing, but to ensure that we use the same allocator ganesha or another consumer does; is that something that we can or should factor out of the api? |
@dang We would need this change to use for memory leak tracing which was reported recently. Can you please review this patch. |
@nuzhatfathima I don't understand why you need this change to trace any way you want to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to leave the capability for Ganesha to provide allocators.
Rejecting.
Directly using malloc and friends should be better than having our own
functions to trace memory allocations using mtrace/muntrace etc.
Changed minor version to 8.