Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocators from ntirpc_pkg_params #163

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

malahal
Copy link

@malahal malahal commented Jan 17, 2019

Directly using malloc and friends should be better than having our own
functions to trace memory allocations using mtrace/muntrace etc.

Changed minor version to 8.

Directly using malloc and friends should be better than having our own
functions to trace memory allocations using mtrace/muntrace etc.

Changed minor version to 8.
@malahal
Copy link
Author

malahal commented Jan 17, 2019

I could keep the structure same and just don't use the passed in allocator/free functions, but I thought this is cleaner. I am assuming that we need [minor]version change here.

@dang
Copy link
Collaborator

dang commented Jan 17, 2019

This needs discussion with Matt, who's traveling this week.

@mattbenjamin
Copy link

mattbenjamin commented Mar 13, 2019

the purpose of this wasn't to use tracing, but to ensure that we use the same allocator ganesha or another consumer does; is that something that we can or should factor out of the api?

@nuzhatfathima
Copy link

@dang We would need this change to use for memory leak tracing which was reported recently. Can you please review this patch.

@mattbenjamin
Copy link

@nuzhatfathima I don't understand why you need this change to trace any way you want to

Copy link
Member

@ffilz ffilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to leave the capability for Ganesha to provide allocators.

Rejecting.

@ffilz ffilz added the wontfix label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants