pseudocode for accepting a filtered pbp #507
Conversation
| @@ -105,9 +109,10 @@ calculate_stats <- function(seasons = nflreadr::most_recent_season(), | |||
| # we need those to identify things like fumbles depending on playtype or | |||
| # first downs depending on playtype | |||
| playstats <- load_playstats(seasons = seasons) %>% | |||
There was a problem hiding this comment.
Need to pull seasons from custom pbp. So the seasons arg is actually ignored in that case
There was a problem hiding this comment.
Yeah, can probably warn/check somehow?
There was a problem hiding this comment.
Yeah I think I'd print a message when custom_pbp is TRUE. But not every time. One of those "once every 8 hours" messages
There was a problem hiding this comment.
Here is an example how to do that with cli https://github.com/nflverse/nflseedR/blob/a8f90520c45ecf5e6d2e8abd61a641613e622761/R/simulations.R#L186-L193
There was a problem hiding this comment.
yeah that's fine. we'd probably want to validate the seasons are in pbp and probably validate that playstats is nonzero rows as well
There was a problem hiding this comment.
actually as long as pbp is nonzero rows playstats should be nonzero rows
There was a problem hiding this comment.
Yeah I never really thought about validation of the seasons arg because load_pbp checks for valid seasons.
There was a problem hiding this comment.
i'd even skip the message about ignoring pbp and just check the custom pbp for the seasons, if any are missing it should warn. then we can call it a day on the season arg since it does what the user expects it to do
tanho63
force-pushed
the
tan/playstats-filtered-pbp
branch
from
b888a3b to
d47f15c
Compare
tanho63
force-pushed
the
tan/maintenance
branch
from
c525c8d to
5da2401
Compare
tanho63
force-pushed
the
tan/playstats-filtered-pbp
branch
3 times, most recently
from
a32b758 to
7f0c4b0
Compare
tanho63
force-pushed
the
tan/playstats-filtered-pbp
branch
from
7f0c4b0 to
32a3585
Compare
No description provided.