update assertions to use descriptive variable names #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SPPearce
reviewed
Nov 27, 2024
| 2. **Minimum Requirement - Process Success + version.yml file**: Always check if the process completes successfully and make at least a snapshot of the version.yml. | ||
|
|
||
| ```groovy | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert snapshot(process.out.versions).match("versions") } | ||
| { assert snapshot(process.out.versions).match() } |
There was a problem hiding this comment.
We should probably swap to using the explicit versions yml option (wherever the link to that is)
There was a problem hiding this comment.
feel free to update and merge :)
There was a problem hiding this comment.
I'd need to find the explicit versions yml code first ;)
|
@SPPearce reminder abt this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@netlify /docs/contributing/nf-test/assertions