-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: save_trimmed_fail is a boolean #125
Conversation
Prepare release 2.0.0
Release 2.2.0
save_trimmed_fail had conflicting settings for boolean and enum of two strings. This removes the enum option.
This PR is against the
|
|
CHANGELOG? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Everything is fine on my side. It seems that a test failed because this PR initially pointed to master (now it's all good).
I still have to bump version 2.3.0dev in CHANGELOG.md (on my way).
Now the CHANGELOG is updated (see #126). Should I ignore the failed test and proceed with the merge? |
The CHANGELOG should contain a mention of this PR and the change made here. But its not. So while the new section in CHANGELOG is now available, it requires the addition of an entry in this PR. |
Sorry for the delay. I have now added this PR to the CHANGELOG for version 2.3.0dev 😅 |
save_trimmed_fail had conflicting settings for boolean and enum of two strings. This removes the enum option.
PR checklist
nf-core lint
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).