Release 2.2.0 #122
Merged
Release 2.2.0 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version 2.2.0dev
update bakta to v1.8.2
Add module dragonflye for long-reads assembly
Template update nf-core tools v2.13.1
Routine updating of installed modules and subworkflows
Prepare release 2.2.0
|
mashehu
approved these changes
Apr 2, 2024
Comment on lines
+51
to
+52
| > [!NOTE] | ||
| > The FastQC plots displayed in the MultiQC report shows _untrimmed_ reads. They may contain adapter sequence and potentially regions with low quality. |
There was a problem hiding this comment.
the previous notation was correct for the website 🙂 (we don't recommend to read the usage and output docs on github, but use the website instead)
d4straub
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good to me!
In CI tests a few warning are occurring that could be fixed, e.g. in Run workflow profile (test_hybrid_dragonflye):
WARN: A process with name 'MINIMAP2_CONSENSUS' is defined more than once in module script: /home/runner/work/bacass/bacass/./workflows/bacass.nf -- Make sure to not define the same function as process
WARN: A process with name 'MINIMAP2_POLISH' is defined more than once in module script: /home/runner/work/bacass/bacass/./workflows/bacass.nf -- Make sure to not define the same function as process
WARN: Access to undefined parameter `genomes` -- Initialise it to a default value eg. `params.genomes = some_value`
10 tasks
Co-authored-by: Daniel Straub <[email protected]>
add reviewer suggestions in PR #122
|
Suggestions added. Thank you so much :)!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).PR description
This PR is for release 2.2.0
Major changes are:
(I think this pr also closess #113 )