Skip to content

Update mermaid to v11 (with promises) #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathpunk
Copy link

Have I ever made pull request to an open source repo? 🤔

I looked for all uses of this version of a Mermaid renderer and made 3 copies of that change. That duplication might not be desirable. Also it is LLM-enhanced code, you might not like the style or the error handling. But! I'll make any changes you like, or someone who has more mature maintainer skillz is welcome to build on this. The chat that led to my solution is here.

@mathpunk
Copy link
Author

I should add, this is undertested: I don't know what the setup environment for base clerk is. I've always just cloned the clerk-demo and then hacked out the bits I don't need.

@mathpunk
Copy link
Author

Hmmmm I restarted my machine and now it looks like I can only get v10 and earlier. There's something I must not understand about caching, either in my notebook or in jsdelivr. I'm hoping that the promise code is still helpful but I'm unclear how to fix the invalid module error I'm getting if I use something later than about 10.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants