Move task error formatting logic into separate class #6551
+246
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
force-pushed
the
task-error-formatter
branch
from
e7e0e85 to
febdfa4
Compare
pditommaso
reviewed
Nov 10, 2025
Member
pditommaso
left a comment
pditommaso
left a comment
There was a problem hiding this comment.
Good opportunity to add unit to add unit tests for TaskErrorFormatter public methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the error formatting logic in
TaskProcessorinto a separate classTaskErrorFormatterReduces cognitive load of reading TaskProcessor, one of the largest classes in the Nextflow runtime
The new class has static compilation enabled, so better error checking
Over time I hope to decouple more pieces from the TaskProcessor hairball in order to make it easier to work with, especially as we continue to evolve with static types and standalone module execution.
The error formatting is a pretty clean cut, so I'm doing it first