-
Notifications
You must be signed in to change notification settings - Fork 744
docs: task.previousTrace directive Documentation #6538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Rashmi Naidu <[email protected]>
Signed-off-by: Rashmi Naidu <[email protected]>
Signed-off-by: Rashmi Naidu <[email protected]>
66be72b to
6051746
Compare
|
Created PR from personal account to add clarification to docs for task.previousTrace directive and accessible metadata fields |
- Clean up Signed-off-by: Chris Hakkaart <[email protected]>
- Fix admonition block end - Apply language consistency Signed-off-by: Chris Hakkaart <[email protected]>
Remove extra lines Signed-off-by: Chris Hakkaart <[email protected]>
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cleaned up the PR so the preview is generated. I've also made suggestions to remove the list and a link that didn't exist, and reduce some of the text. Please check the meaning is retained.
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - I was OoO for a few days and forgot to comment this. This looks good to me now. I'll ask @bentsherman to give it a quick look to make sure everything is correct, then it should be good to merge.
Signed-off-by: Ben Sherman <[email protected]>
PR Checklist: Improve
task.previousTraceDocumentationSummary of Changes
This PR enhances the documentation for the
task.previousTracefield to provide explicit guidance on accessing runtime metrics from previous task attempts. The changes address user confusion around field availability and access patterns, particularly for implementing retry logic based on performance metrics.Key Improvements
task.previousTracep-naming pattern for percentage fields (workaround for Groovy syntax limitations with%)Pre-Submission Checklist
Code Quality
Documentation
Testing
pcpupmem) are correctly explainedReview Readiness
Completeness
Detailed Change Summary
Documentation Enhancements
task.previousTrace(e.g., memory usage, CPU metrics)pcpupmempattern as a Groovy workaround for percentage fields (can't use%directly in identifiers)Files Modified
task.previousTracefield referenceImpact
Review Notes
For Reviewers: Please verify that all field names and access patterns match the actual implementation in the codebase. Pay particular attention to:
pcpupmemnaming explanation