-
Notifications
You must be signed in to change notification settings - Fork 683
PoC for CID store annotations and workflow outputs structure #5885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far. Left a few minor suggestions. I will try to play with it when I have time
modules/nextflow/src/main/groovy/nextflow/extension/PublishOp.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/trace/TraceObserver.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/trace/TraceObserver.groovy
Outdated
Show resolved
Hide resolved
modules/nf-cid/src/main/nextflow/data/cid/model/WorkflowResults.groovy
Outdated
Show resolved
Hide resolved
I have updated the code with annotations field in the output. It can be Map or a closure. The closure is evaluated per sample. So, we could support the case of adding sample information as annotation such as the sampleId
|
modules/nextflow/src/main/groovy/nextflow/extension/PublishOp.groovy
Outdated
Show resolved
Hide resolved
void annotations(Map value) { | ||
setOption('annotations', value) | ||
} | ||
|
||
void annotations(Closure value) { | ||
setOption('annotations', value) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: decide whether to use tags
or phase it out in favor of annotations
Last changes:
|
@jorgee also some conflicts to solve here 🙏 |
Signed-off-by: jorgee <[email protected]>
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Jorge Ejarque <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
--------- Signed-off-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
c656fda
to
4548915
Compare
Signed-off-by: jorgee <[email protected]>
Last changes:
|
modules/nextflow/src/main/groovy/nextflow/trace/TraceObserver.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Also added So, we can look for the task results of a certain task run with |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Changed the constructor of GsonEncoder because, according gpt, |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Added the serialization of nulls |
return files | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should return if it's not a Path
or a collection?
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Merging this, and continue the discussion about open points in the baseline PR |
This PR is a PoC for adding the annotations to metadata entries in the CID and restructure the workflow outputs in the way defined in output DSL
It is currently getting annotations from tags
Tested with a variation of the e2e test with a small modification to include tags.
An example of is the generated WorkflowResults.
publishedData
is a list of all files published and outputs are how they are defined as records in the ouputsDslWorkflow output files are annotated with the provided tags