Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing int instead of Snowflake abc where possible #1140

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Oct 24, 2023

Summary

#474

Doing this per module:

  • nextcord
    • ext
      • commands
        • bot.py
        • cog.py (pass)
        • context.py (pass)
        • converter.py (pass)
        • cooldown.py (pass)
        • core.py (pass)
        • errors.py (pass)
        • flags.py (pass)
        • help.py (pass)
        • view.py (pass)
      • tasks
        • __init__.py (pass)
    • abc.py
    • activity.py (pass)
    • appinfo.py (pass)
    • application_commands.py
    • asset.py (pass)
    • audit_logs.py (pass)
    • auto_moderation.py
    • backoff.py (pass)
    • bans.py (pass)
    • channel.py
    • client.py (pass)

(pass) means nothing in the module requires any changes.

Reviews and nitpicks are welcome.

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@teaishealthy
Copy link
Collaborator

Why is the TypeAlias called SnowflakeIntT, ending with T usually indicates a TypeVar. I'd prefer SnowflakeOrInt (might be better to use Snowflake | int in the future) or simply SnowflakeInt

@EmreTech EmreTech changed the title [WIP] Allow passing int instead of Snowflake where possible feat: allow passing int instead of Snowflake abc where possible Nov 8, 2023
@EmreTech EmreTech added t: enhancement Type: enhancement - new feature or request p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: enhancement Type: enhancement - new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants