Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 3.12 to supported lists #1135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: add 3.12 to supported lists #1135

wants to merge 1 commit into from

Conversation

ooliver1
Copy link
Member

@ooliver1 ooliver1 commented Oct 3, 2023

Summary

Note
This too relies on #1126 as without poetry, the 3.12 PyPI specifier would have to be added to package metadata as well. This is a draft until that is merged.

Python 3.12 is now stable 馃殌. The optimisations are amazing but there's not all too much to benefit from otherwise this time round. Nearly all of the deprecations do not affect us, and there are only module removals (asynchat, asyncore, imp, distutils).

The get_event_loop changes may need some refactoring for both the examples, Client and Webhooks, as that will eventually not create a new loop implicitly (slightly irritating but makes sense).

datetime.datetime.utcnow and datetime.utcfromtimestamp have also been deprecated. This has been solved in #1000 with the DTZ set of rules.

audioop will be removed in 3.13 too, which is used partially in player.py.

The only removals for 3.14 are some deprecations in 3.13 of course.

Don't forget to check the porting section too for behaviour changes in 3.12 for your own bots such as randrange.

@ooliver1 ooliver1 added p: medium Priority: medium - should be worked on in the near future t: meta Type: meta - this does not relate to code or documentation s: awaiting review Status: the issue or PR is awaiting reviews labels Oct 3, 2023
@ooliver1 ooliver1 marked this pull request as draft October 3, 2023 16:41
@ooliver1 ooliver1 marked this pull request as ready for review December 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: meta Type: meta - this does not relate to code or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants