feat: add saml:user:add command to pre-provision users

[guerby]

feat: add saml:user:add command to pre-provision users, fix #939

[blizzz]

Thank you for your contribution!

Some suggestions on user facing text mostly. Please update the commit message to be meaningful, e.g. how i edited the PRs title.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[blizzz]

FWIW Github does not create notifications when a commit was added.

[guerby]

FWIW Github does not create notifications when a commit was added.

I have commited the change to make email VALUE_OPTIONAL, I think this is the last pending review item, let me know if I missed something, thanks!

[blizzz]

Thanks! Please update with a rebase, not merging master hereinto.

[guerby]

Thanks! Please update with a rebase, not merging master hereinto.

I have followed the DCO suggestions:

git pull
git rebase HEAD~9 --signoff
git push --force-with-lease origin patch-user-add-fix-939

I hope this is correct :)

[blizzz]

I use git rebase master instead of git rebase HEAD~9 but it looks good anyhow ✔️

[blizzz]

composer i && composer run cs:fix should help solve the last failing test.

Plusses, if the UPDATE $filename commits can be squashed to their parent :)

[guerby]

composer i && composer run cs:fix

On my debian 12 I did apt-get install composer php-xml php-curl and ran composer i && composer run cs:fix.

For the squash part I'm reading git documentation, I assume you mean commits 29ba794 2cced28 and b886e05 ?

[blizzz]

composer i && composer run cs:fix

On my debian 12 I did apt-get install composer php-xml php-curl and ran composer i && composer run cs:fix.

Thanks!

For the squash part I'm reading git documentation, I assume you mean commits 29ba794 2cced28 and b886e05 ?

Aye 🙂

[guerby]

composer i && composer run cs:fix

On my debian 12 I did apt-get install composer php-xml php-curl and ran composer i && composer run cs:fix.

Thanks!

For the squash part I'm reading git documentation, I assume you mean commits 29ba794 2cced28 and b886e05 ?

Aye 🙂

Hi, I think I've done the squash and fix whitespace that composer missed. The other lint errors are not in my code AFAIK.

Let me know if it look ok to you and thanks again!

[blizzz]

i think something went wrong, the changes in the l10n should not be here though (they will be imported automatically from the translation tool)

[guerby]

i think something went wrong, the changes in the l10n should not be here though (they will be imported automatically from the translation tool)

Do you have a suggestion on what to do to fix this PR (remove unwanted changes dragged from probably one of my git commands)?

[guerby]

i think something went wrong, the changes in the l10n should not be here though (they will be imported automatically from the translation tool)

I did the following to get rid of the unwanted commits:

git rebase -i HEAD~20 # removed the "pick" lines of all unwanted commits
git push origin patch-user-add-fix-939 --force-with-lease

They seem to have disappeared now.

[guerby]

Hmm they seem to reappear immediately, may be some bot is doing something?

[blizzz]

Hmm they seem to reappear immediately, may be some bot is doing something?

Is your master checkout up to date?

[ZephOne]

Suggested change

	->setDescription('adds an saml account')
	->setDescription('Add a SAML account')

[guerby]

@blizzz do you have a suggestion on how to make progress?

I did again the following:

git pull origin master --rebase
git push origin patch-user-add-fix-939 --force-with-lease

[guerby]

Then I cliked on github web "merge" button