Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Context): do not show hidden columns #1092

Merged
merged 1 commit into from
May 29, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 16, 2024

There are two endpoints for loading the columns of a view. When using that one against a table scope, all columns will be returned, while fetching only those against the direct view endpoint, only those are returned that actually should be displayed. When opening the classic view, the later is called. In Contexts/Applications, the first one was called resulting in empty columns. This changes fixes it.

In the screenshot you see that "Last time spotted" is not shown after the change, as it is supposed to given the View configuration (hence no values are shown before either).

Before After
before after

@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels May 16, 2024
@blizzz
Copy link
Member Author

blizzz commented May 16, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 16, 2024
@blizzz blizzz requested a review from elzody May 17, 2024 12:42
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@enjeck enjeck merged commit fa82ee7 into main May 29, 2024
45 checks passed
@enjeck enjeck deleted the fix/noid/hide-hidden-cols-context branch May 29, 2024 07:12
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants