feat: introduce PollManager #14038
feat: introduce PollManager #14038
Conversation
Antreesy
added
3. to review
enhancement
feature: frontend 🖌️
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/13439/poll-management
branch
from
f95083c to
7f7cfea
Compare
| canCreatePollDrafts() { | ||
| return hasTalkFeature(this.token, 'talk-polls-drafts') && this.$store.getters.isModerator | ||
| && [CONVERSATION.TYPE.GROUP, CONVERSATION.TYPE.PUBLIC].includes(this.conversation.type) | ||
| }, |
There was a problem hiding this comment.
| canCreatePollDrafts() { | |
| return hasTalkFeature(this.token, 'talk-polls-drafts') && this.$store.getters.isModerator | |
| && [CONVERSATION.TYPE.GROUP, CONVERSATION.TYPE.PUBLIC].includes(this.conversation.type) | |
| }, | |
| canCreatePollDrafts() { | |
| return hasTalkFeature(this.token, 'talk-polls-drafts') | |
| }, |
Redundancy as LobbySettings is wrapped with those conditions
| @@ -182,6 +197,11 @@ export default { | |||
| getRelativeTime() { | |||
| return futureRelativeTime(this.lobbyTimer) | |||
| }, | |||
|
|
|||
| canCreatePollDrafts() { | |||
| return hasTalkFeature(this.token, 'talk-polls-drafts') && this.$store.getters.isModerator | |||
There was a problem hiding this comment.
this.$store.getters.isModerator is checking moderation against the token from root 💀
| @@ -223,14 +225,15 @@ async function createPoll() { | |||
| /** | |||
| * Pre-fills form from the draft | |||
| * @param id poll draft ID | |||
| * @param isAlreadyOpened poll draft ID | |||
| * @param fromDrafts whether editor was opened from drafts handler | |||
There was a problem hiding this comment.
fromDrafts can be used to hide "Browse poll drafts" button as it feels repetitive and user would intuitively pick from the poll drafts handler rather then browsing from that button (when it is opened in lobby settings or shared Items tab).
There was a problem hiding this comment.
Also, not related but todo, hide/disable export poll button when the poll inputs are all empty
There was a problem hiding this comment.
Minor: we need a loading state while the poll drafts are being fetched.
| @@ -289,7 +292,7 @@ async function createPollDraft() { | |||
| * Open a PollDraftHandler dialog | |||
| */ | |||
| function openPollDraftHandler() { | |||
| EventBus.emit('poll-drafts-open') | |||
| EventBus.emit('poll-drafts-open', {}) | |||
There was a problem hiding this comment.
Selector needs to be passed here, as the editor can be opened in settings (create a new poll) so clicking "back" mounts the drafts handler correctly
| import { hasTalkFeature } from '../../services/CapabilitiesManager.ts' | ||
| import { EventBus } from '../../services/EventBus.ts' | ||
|
|
||
| const store = useStore() |
| showPollDraftHandler.value = false | ||
| }) | ||
| } | ||
|
|
I'd say to not to block it, as the other conversation settings are also accessible, so we keep the same pattern |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist