-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Screen): allow to zoom and pan screenshare content #14028
base: main
Are you sure you want to change the base?
Conversation
Looks good on a first glance 👍 |
3330e9c
to
107c559
Compare
@@ -182,6 +203,9 @@ export default { | |||
&--fill { | |||
object-fit: cover; | |||
} | |||
&--magnify { | |||
cursor: zoom-in; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zoom-in
cursor stays even when the cursor is used to zoom-out
or move the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the cursor normal and change it on action (e.g: when zooming in -> zoom-in
etc)? we can mention that the screen is zoomable/movable in the shortcuts section so user can be informed there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound fine. changing on action would be more disturbing, as scroll event is short.
9c95b70
to
d6eeb98
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
107c559
to
de77116
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
2024-12-23_16h01_36.mp4
🚧 Tasks
🏁 Checklist