Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add selector for audiooutput, allow to test different speakers #12667

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 10, 2024

[wip]
[skip ci]

☑️ Resolves

  • Fix #…
Current To discuss
image image

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy self-assigned this Jul 10, 2024
@Antreesy
Copy link
Contributor Author

Since the approach is working (apart from Safari browsers), can we get it in for troubleshooting purposes, or as a step 1 to #7125 ?

image

cc @nextcloud/designers @nickvergessen @DorraJaouad

@@ -107,7 +107,12 @@
:device-id="videoInputId"
@refresh="updateDevices"
@update:deviceId="handleVideoInputIdChange" />
<MediaDevicesSpeakerTest />
<MediaDevicesSelector kind="audiooutput"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediaDevicesSelector has not icon for this defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to discuss it first before start actually doing something.
For now, see the mock for the reference

@Crashdummyy
Copy link

Is there any ongoing work regarding this selection ?
me and I guess a load of other people on issue 7125 would be quite happy to get this feature

@Antreesy
Copy link
Contributor Author

any ongoing work

Hi! we're focused on another area at the moment, but I can try to rebase it on recent changes and we'll see if it's worth including in the app

@Crashdummyy
Copy link

any ongoing work

Hi! we're focused on another area at the moment, but I can try to rebase it on recent changes and we'll see if it's worth including in the app

wow thanks for the quick reply.
I'd really liked that.
My vue sucks really bad tho...
Did I get it right that while using this change I could click on "Test speaker" in the media settings which should persist the selected audiodevice/audiosink to the current session ?

@Antreesy
Copy link
Contributor Author

should persist the selected audiodevice/audiosink to the current session ?

yes, but only for specific HTMLAudioElement. In this case, waiting sound music should persist until the page reload.
BUT not another sounds in call, neither participants voices. Each audio should be adjusted separately. As alternative, change of output device on system value -> then all audio elements should use the default one for OS/browser

that's the idea for testing only, not the complete solution of issue mentioned

@Crashdummyy
Copy link

should persist the selected audiodevice/audiosink to the current session ?

yes, but only for specific HTMLAudioElement. In this case, waiting sound music should persist until the page reload. BUT not another sounds in call, neither participants voices. Each audio should be adjusted separately. As alternative, change of output device on system value -> then all audio elements should use the default one for OS/browser

that's the idea for testing only, not the complete solution of issue mentioned

Thanks for the explanation which means I didn't grasp your PR correctly.
The missing audio selection prevents me from using spreed on my Android device as it appears to not be possible anymore to select the bluetooth headset to be used as output device.

@Antreesy
Copy link
Contributor Author

on my Android device

I see now =) I'm afraid, we are providing a minimal support for Web version on mobile browsers, so if possible, consider for now using Talk app for Android.

@Crashdummyy
Copy link

on my Android device

I see now =) I'm afraid, we are providing a minimal support for Web version on mobile browsers, so if possible, consider for now using Talk app for Android.

I'd really like to do that but there are the same issues like most other rtc Apps ( e.g signal )
I cant select the audio input there.
So when I connect my bluetooth headset I get the autiooutput there but the audio input.
The browser is vice versa and let me select the microphone but not the speaker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants