-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add selector for audiooutput, allow to test different speakers #12667
base: main
Are you sure you want to change the base?
Conversation
[wip] [skip ci] Signed-off-by: Maksim Sukharev <[email protected]>
Since the approach is working (apart from Safari browsers), can we get it in for troubleshooting purposes, or as a step 1 to #7125 ? cc @nextcloud/designers @nickvergessen @DorraJaouad |
@@ -107,7 +107,12 @@ | |||
:device-id="videoInputId" | |||
@refresh="updateDevices" | |||
@update:deviceId="handleVideoInputIdChange" /> | |||
<MediaDevicesSpeakerTest /> | |||
<MediaDevicesSelector kind="audiooutput" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MediaDevicesSelector has not icon for this defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to discuss it first before start actually doing something.
For now, see the mock for the reference
Is there any ongoing work regarding this selection ? |
Hi! we're focused on another area at the moment, but I can try to rebase it on recent changes and we'll see if it's worth including in the app |
wow thanks for the quick reply. |
yes, but only for specific HTMLAudioElement. In this case, waiting sound music should persist until the page reload. that's the idea for testing only, not the complete solution of issue mentioned |
Thanks for the explanation which means I didn't grasp your PR correctly. |
I see now =) I'm afraid, we are providing a minimal support for Web version on mobile browsers, so if possible, consider for now using Talk app for Android. |
I'd really like to do that but there are the same issues like most other rtc Apps ( e.g signal ) |
[wip]
[skip ci]
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required