-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/apply rector set to apps #50577
base: master
Are you sure you want to change the base?
Enh/apply rector set to apps #50577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for caldav/carddav
Those 2 are wrong, should be 'OCP\IUserManager' and 'OCP\IGroupManager'. |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
92966bf
to
e37fb47
Compare
// Deprecated since 20.0.0 Use 'get(\OCP\Files\AppData\IAppDataFactory')->get($app) instead
new LegacyGetterToOcpServerGet('getAppDataDir', 'OCP\Files\IAppData'), This is wrong in 25 set. For this PR it can easily be fixed manually I think. |
Upstream fix: nextcloud-libraries/rector#41 |
Summary
NextcloudSets::NEXTCLOUD_25
to configurationYou can note that
\OC::$server->get
calls are correctly replaced but not\OC::$server->query
ones, that’s an oversight of the Set and will need to be fixed upstream.Apart from that the changes look sound to me.
Checklist