Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix folder preview for favorites widget #50576

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

provokateurin
Copy link
Member

Summary

Folders don't have a preview and result in 404.
Alternatively we could change the endpoint to also generate "previews" for folders when mimeFallback=true.
That would make it more robust overall which would be nice.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Jan 30, 2025
@provokateurin provokateurin added this to the Nextcloud 32 milestone Jan 30, 2025
@provokateurin
Copy link
Member Author

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Jan 31, 2025

Alternatively we could change the endpoint to also generate "previews" for folders when mimeFallback=true.

👍 I think if the fallback was requested then we should also add that fallback (folder icon).

@provokateurin
Copy link
Member Author

Ok, then I will add this as an enhancement on master, but not backport it as a fix for 31.

@provokateurin provokateurin force-pushed the fix/files/favorites-widget-folder-preview branch from e3d61a5 to ea68ad6 Compare February 3, 2025 08:36
@provokateurin provokateurin force-pushed the fix/files/favorites-widget-folder-preview branch from ea68ad6 to 6ada9dd Compare February 3, 2025 09:25
@provokateurin provokateurin merged commit c38aa33 into master Feb 3, 2025
189 checks passed
@provokateurin provokateurin deleted the fix/files/favorites-widget-folder-preview branch February 3, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants