-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add example contact on first login #50156
Open
hamza221
wants to merge
12
commits into
master
Choose a base branch
from
feat/cardav-example-contact
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
688166c
feat: add example contact on first login
hamza221 067442e
fixup! feat: add example contact on first login
hamza221 1b9425c
fixup! feat: add example contact on first login
hamza221 db4c47b
fixup! feat: add example contact on first login
hamza221 37cd3f5
fixup! feat: add example contact on first login
hamza221 7eff8a5
fixup! feat: add example contact on first login
hamza221 2965fc4
fixup! feat: add example contact on first login
hamza221 ef21e65
fixup! feat: add example contact on first login
hamza221 245f7bf
fixup! feat: add example contact on first login
hamza221 0da61b1
fixup! feat: add example contact on first login
hamza221 979db68
fixup! feat: add example contact on first login
hamza221 b6cd5b0
fixup! feat: add example contact on first login
hamza221 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| <?php | ||
| /** | ||
| * SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\DAV\Controller; | ||
|
|
||
| use OCA\DAV\AppInfo\Application; | ||
| use OCP\App\IAppManager; | ||
| use OCP\AppFramework\ApiController; | ||
| use OCP\AppFramework\Http; | ||
| use OCP\AppFramework\Http\JSONResponse; | ||
| use OCP\Files\AppData\IAppDataFactory; | ||
| use OCP\Files\IAppData; | ||
| use OCP\Files\NotFoundException; | ||
| use OCP\IConfig; | ||
| use OCP\IRequest; | ||
|
|
||
| class ExampleContentController extends ApiController { | ||
|
|
||
| /** @var IAppData */ | ||
| private $appData; | ||
| public function __construct( | ||
| IRequest $request, | ||
| private IConfig $config, | ||
| private IAppDataFactory $appDataFactory, | ||
| private IAppManager $appManager, | ||
| ) { | ||
| parent::__construct(Application::APP_ID, $request); | ||
| $this->appData = $this->appDataFactory->get('dav'); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * update appconfig (admin setting) | ||
| * | ||
| * @param string allow the value to set | ||
| * | ||
| * @return JSONResponse an empty JSONResponse with respective http status code | ||
| */ | ||
| public function setAppConfig($key, $allow) { | ||
| if ($allow === 'yes' && $key === 'enableDefaultContact' && !$this->defaultContactExists()) { | ||
| $this->setCard(); | ||
| } | ||
| $this->config->setAppValue(Application::APP_ID, $key, $allow); | ||
| return new JSONResponse([], Http::STATUS_OK); | ||
| } | ||
|
|
||
| public function setDefaultContact(?string $contactData = null) { | ||
| if (!$this->config->getAppValue(Application::APP_ID, 'enableDefaultContact', 'no')) { | ||
| return new JSONResponse([], Http::STATUS_FORBIDDEN); | ||
| } | ||
| $this->setCard($contactData); | ||
| return new JSONResponse([], Http::STATUS_OK); | ||
| } | ||
|
|
||
| private function setCard(?string $cardData = null) { | ||
| try { | ||
| $folder = $this->appData->getFolder('defaultContact'); | ||
| } catch (NotFoundException $e) { | ||
| $folder = $this->appData->newFolder('defaultContact'); | ||
| } | ||
|
|
||
| if (is_null($cardData)) { | ||
| $cardData = file_get_contents(__DIR__ . '/../ExampleContentFiles/exampleContact.vcf'); | ||
| } | ||
|
|
||
| $file = (!$folder->fileExists('defaultContact.vcf')) ? $folder->newFile('defaultContact.vcf') : $folder->getFile('defaultContact.vcf'); | ||
| $file->putContent($cardData); | ||
| } | ||
|
|
||
| private function defaultContactExists(): bool { | ||
| try { | ||
| $folder = $this->appData->getFolder('defaultContact'); | ||
| } catch (NotFoundException $e) { | ||
| return false; | ||
| } | ||
| return $folder->fileExists('defaultContact.vcf'); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't like having a general app config route here. Perhaps it could be specialized to only set the default contact setting for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it in case you want to rebase the calendar content on top, I'm okay with changing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed it with Christoph and this is not going to happen for 31.