Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Add nextTick to saveChanges #49343

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

marcelklehr
Copy link
Member

to alleviate race condition introduced by vue lib update.

Checklist

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be:

onSaveChanges() {
    this.$nextTick(() => this.saveChanges())
},

both works

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the settings not saving (after recompiling locally)

to alleviate race condition

fixes #49335

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@nickvergessen nickvergessen merged commit 4b769f6 into master Nov 18, 2024
116 of 118 checks passed
@nickvergessen nickvergessen deleted the fix/ai-settings branch November 18, 2024 21:10
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Changing TaskProcessing selects wrong provider
4 participants