Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Try to delete existing target #49315

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Nov 15, 2024

Summary

Should get rid of logs like:

{
  "reqId": "iq8oEiCJ1Uc7WrCf9uNP",
  "level": 3,
  "app": "PHP",
  "method": "GET",
  "url": "/index.php/apps/files/api/v1/thumbnail/256/256/00_COMMUN/ORGAN/EST-LES/File.pdf",
  "message": "unlink(/var/www/data/appdata_ocwfs52oscxg/preview/d/a/d/3/f/6/3/4158280/256-256-crop.webp): No such file or directory at /var/www/nextcloud/lib/private/Files/Storage/Local.php#348",
  "userAgent": "Mozilla/5.0 (Android) Nextcloud-android/3.29.2",
  "version": "29.0.9.2",
  "data": {
    "app": "PHP"
  },
}

Checklist

@solracsf solracsf added bug 3. to review Waiting for reviews labels Nov 15, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Nov 15, 2024
Signed-off-by: Git'Fellow <[email protected]>

Add same logic to common storage
@solracsf solracsf force-pushed the deleteExistingTarget branch from e1bc4bf to 8755bf1 Compare November 20, 2024 08:42
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 🤷

@susnux susnux requested review from provokateurin and removed request for CarlSchwan November 20, 2024 18:16
@provokateurin provokateurin merged commit bdb3d63 into master Nov 20, 2024
187 checks passed
@provokateurin provokateurin deleted the deleteExistingTarget branch November 20, 2024 18:47
@skjnldsv
Copy link
Member

Backports?

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable29

@skjnldsv
Copy link
Member

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants