Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unified-search): Close on second ctrl+f #48850

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 23, 2024

Summary

A second ctrl+f should close the unified search again to use the native browser search.

Checklist

@susnux
Copy link
Contributor Author

susnux commented Oct 23, 2024

/backport to stable30

@susnux susnux added this to the Nextcloud 31 milestone Oct 23, 2024
@provokateurin
Copy link
Member

Why workaround it first instead of removing this shortcut override completely?

@susnux
Copy link
Contributor Author

susnux commented Oct 23, 2024

/compile

@susnux
Copy link
Contributor Author

susnux commented Oct 23, 2024

Why workaround it first instead of removing this shortcut override completely?

Because we can not break existing behavior on stable branches. For 31 we then can on a follow up remove the behavior.

@susnux
Copy link
Contributor Author

susnux commented Oct 23, 2024

/backport to stable29

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this recently and it's a bit frustrating when you are trying to find something on page. Thank you!

Also only add the event listener if short-cuts are not disabled for accessibility reasons.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@nfebe
Copy link
Contributor

nfebe commented Oct 23, 2024

Because we can not break existing behavior on stable branches. For 31 we then can on a follow up remove the behavior.

Moreover this was not a thing with new unified search we had to actually re-introduce it because it has always been a Nextcloud feature.

I think, (CTRL+F)*2 is a decent way to handle this and still keep this "feature"

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/unified-search-ctrl-f branch from e35a320 to ed2295a Compare October 23, 2024 11:26
@susnux susnux enabled auto-merge October 23, 2024 11:26
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@susnux susnux merged commit d915a7c into master Oct 23, 2024
118 checks passed
@susnux susnux deleted the fix/unified-search-ctrl-f branch October 23, 2024 13:11
Copy link

backportbot bot commented Oct 23, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/48850/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d7376891 ed2295a0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48850/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants