Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Vite for bundling and allow to share modules #43553

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Migrate to Vite for bundling and allow to share modules #43553

wants to merge 11 commits into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 13, 2024

Summary

TBD

TODO

  • Testing

Checklist

@susnux susnux mentioned this pull request Feb 13, 2024
Merged
4 tasks
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@juliushaertl juliushaertl mentioned this pull request Mar 26, 2024
Open
3 tasks
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@susnux susnux force-pushed the chore/migrate-vite branch 5 times, most recently from 4ff8492 to 3cc62a4 Compare May 3, 2024 14:38
@susnux
Copy link
Contributor Author

susnux commented May 3, 2024

Current status:

@susnux susnux mentioned this pull request May 3, 2024
Merged
4 tasks
susnux added 11 commits June 8, 2024 15:03
@susnux
feat!: Migrate from webpack to vite for bundling
7a942b9 
Also use patched `davclient.js` package

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Remove now unneeded webpack nounce configuration
07f3140 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix!: Split legacy dependency modules into own chunk
aa214a3 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Set up module-preload for Vite
57770d6 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
feat: Allow sharing JavaScript modules across apps and core
701ce59 
Initially `vue` and `@nextcloud/vue` are shared by server core.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(settings): Adjust invalid import
dfeb2e6 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Precompile systemtags handlebars templates
f964571 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(UnifiedSearch): Fix imports to work without implicit window as `g…
89354fd 
…lobalThis`

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(dashboard): Adjust code to work without implicit window as `globa…
9b1b663 
…lThis`

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Try to fix karma to run with modules
dfb7f43 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore: Compile assets
350666e 
Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv will be requested when the pull request is marked ready for review skjnldsv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @skjnldsv