Improve shared status button #41453
Merged
Improve shared status button #41453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoambrosini
commented
Nov 14, 2023
marcoambrosini
commented
- partially fixes --> Beta design feedback #41450
marcoambrosini
requested review from
nickvergessen,
jancborchardt,
skjnldsv,
a team,
sorbaugh and
emoral435
and removed request for
a team
jancborchardt
approved these changes
Nov 14, 2023
|
|
||
| <style lang="scss" scoped> | ||
|
|
||
| :deep(.button-vue--icon-and-text, .files-list__row-action-sharing-status) { |
There was a problem hiding this comment.
This means one of the libraries has an issue?
Do all apps that use the filepicker from nextcloud/dialogs need to cheat like this?
There was a problem hiding this comment.
Sorry, In the rush of those days I missed this comment.
No: this whole set of changes were temporary hacks for files screenshots sake and a less than ideal solutions. I wouldn't have wanted to replicate them in other places.
We talked about using two columns for owner and shared status and doing this properly in the near future.
Merged
AndyScherzinger
added
design
emoral435
approved these changes
Nov 14, 2023
emoral435
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
124d00e to
28efb51
Compare
susnux
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
28efb51 to
f3f7415
Compare
Signed-off-by: Marco <[email protected]>
susnux
force-pushed
the
enh/41450/improve-shared-status-button
branch
from
f3f7415 to
c2c5994
Compare
|
Super nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.