Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenAPI attribute to allow multiple scopes #41175

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add OpenAPI attribute to allow multiple scopes #41175

merged 1 commit into from
Nov 7, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 28, 2023 •
edited
Loading

🚧 Todo

  • Add OpenAPIattribute
  • Fix the extractor to handle the new attribute
  • Deprecate IgnoreOpenAPI attribute
  • Replace existing IgnoreOpenAPI attributes

Checklist

@nickvergessen nickvergessen added the 2. developing Work in progress label Oct 28, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Oct 28, 2023
@nickvergessen nickvergessen self-assigned this Oct 28, 2023
@nickvergessen nickvergessen marked this pull request as draft October 28, 2023 13:59
@nickvergessen nickvergessen mentioned this pull request Oct 28, 2023
Merged
5 tasks
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@nickvergessen nickvergessen force-pushed the feat/noid/openapi-scopes branch from 8cae45c to 99e5f79 Compare November 3, 2023 08:13
@nickvergessen nickvergessen added 3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update and removed 2. developing Work in progress labels Nov 3, 2023
@nickvergessen nickvergessen marked this pull request as ready for review November 3, 2023 08:14
provokateurin
provokateurin requested changes Nov 3, 2023
View reviewed changes
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Http/Attribute/OpenAPI.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/noid/openapi-scopes branch from 99e5f79 to ffc1bb7 Compare November 3, 2023 08:25
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@nickvergessen nickvergessen merged commit a77af05 into master Nov 7, 2023
49 checks passed
@nickvergessen nickvergessen deleted the feat/noid/openapi-scopes branch November 7, 2023 07:39
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

@provokateurin provokateurin provokateurin approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@marcelklehr marcelklehr Awaiting requested review from marcelklehr

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @bigcat88 @provokateurin @andrey18106