implements search on null/notnull metadata

Signed-off-by: Maxence Lange <[email protected]>
nextcloud · Nov 14, 2023 · 8eba418 · 8eba418
1 parent a2770e0
commit 8eba418
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/apps/dav/lib/Files/FileSearchBackend.php b/apps/dav/lib/Files/FileSearchBackend.php
@@ -382,7 +382,9 @@ private function transformSearchOperation(Operator $operator) {
 					return new SearchComparison($trimmedType, $this->mapPropertyNameToColumn($property), $value);
 				}
 
-				// no break
+			case Operator::OPERATION_IS_DEFINED:
+				$property = $operator->arguments[0];
+				return new SearchComparison('null', substr($property->name, strlen(FilesPlugin::FILE_METADATA_PREFIX)), '', IMetadataQuery::EXTRA);
 			case Operator::OPERATION_IS_COLLECTION:
 				return new SearchComparison('eq', 'mimetype', ICacheEntry::DIRECTORY_MIMETYPE);
 			default:

diff --git a/lib/private/Files/Cache/SearchBuilder.php b/lib/private/Files/Cache/SearchBuilder.php
@@ -47,6 +47,7 @@ class SearchBuilder {
 		ISearchComparison::COMPARE_GREATER_THAN_EQUAL => 'gte',
 		ISearchComparison::COMPARE_LESS_THAN => 'lt',
 		ISearchComparison::COMPARE_LESS_THAN_EQUAL => 'lte',
+		ISearchComparison::COMPARE_NULL => 'isNull',
 	];
 
 	protected static $searchOperatorNegativeMap = [
@@ -57,6 +58,7 @@ class SearchBuilder {
 		ISearchComparison::COMPARE_GREATER_THAN_EQUAL => 'lt',
 		ISearchComparison::COMPARE_LESS_THAN => 'gte',
 		ISearchComparison::COMPARE_LESS_THAN_EQUAL => 'gt',
+		ISearchComparison::COMPARE_NULL => 'isNotNull',
 	];
 
 	public const TAG_FAVORITE = '_$!<Favorite>!$_';

diff --git a/lib/public/Files/Search/ISearchComparison.php b/lib/public/Files/Search/ISearchComparison.php
@@ -35,6 +35,7 @@ interface ISearchComparison extends ISearchOperator {
 	public const COMPARE_LESS_THAN_EQUAL = 'lte';
 	public const COMPARE_LIKE = 'like';
 	public const COMPARE_LIKE_CASE_SENSITIVE = 'clike';
+	public const COMPARE_NULL = 'null';
 
 	public const HINT_PATH_EQ_HASH = 'path_eq_hash'; // transform `path = "$path"` into `path_hash = md5("$path")`, on by default