fix(scopes): Add scope suffix even for single scopes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
nickvergessen
approved these changes
Jan 18, 2024
|
Otherwise the scopes make no sense when all endpoints have the same scope. In some cases you might want to get all specs that are federation only, so you would check for each app if it has a openapi-federation.json. Now if that isn't present it would never detect it. |
|
I thought about this again and I agree that it is weird. Also makes it impossible to fallback to openapi.json if no openapi-full.json is present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app has all routes under a single scope we still want to have suffix (unless it is default ofc).
Affected apps are cloud_federation_api (where everything should be federation) and settings, updatenotification and user_ldap where everything is administration.