Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Helpers): Fix ref collection #80

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

provokateurin
Copy link
Member

Broken after #24.

The problem is that allOf, oneOf and anyOf contain lists of schemas, while properties contains a map of schemas and additionalProperties is a schema directly. Using recursive walk solves this and will not encounter problems in the future.

The dashboard app is affected (https://github.com/nextcloud/server/pull/42888/files#diff-34caa6070d1d05fddc37174348f4f3a601f7d9a3c01816e68c1303b449cd575b)

@provokateurin provokateurin added the bug Something isn't working label Jan 17, 2024
@nickvergessen nickvergessen merged commit df8b4c8 into main Jan 18, 2024
10 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/helpers/ref-collection branch January 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants