feat(CI): Run tests on some known bigger repos #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
feat/noid/dont-break-on-repos
branch
4 times, most recently
from
1b8c17a to
8be21d2
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/noid/dont-break-on-repos
branch
from
8be21d2 to
bcee8f3
Compare
Comment on lines
+79
to
+91
| summary: | ||
| permissions: | ||
| contents: none | ||
| runs-on: ubuntu-latest | ||
| needs: openapi-repositories | ||
|
|
||
| if: always() | ||
|
|
||
| name: openapi-repositories-summary | ||
|
|
||
| steps: | ||
| - name: Summary status | ||
| run: if ${{ needs.openapi-repositories.result != 'success' && needs.openapi-repositories.result != 'skipped' }}; then exit 1; fi |
There was a problem hiding this comment.
Why do we need this? These jobs should not be set to required because sometimes there will be changes that cause a diff that was intended
There was a problem hiding this comment.
it's not failing on diff, only when generate-specs does a non-0 exit
There was a problem hiding this comment.
I thought the point was that it fails on diffs so that we can see when a PR changes the output
There was a problem hiding this comment.
It shows the diff and fails when the command fails, so the best of both worlds I would say 😅
Signed-off-by: Joas Schilling <[email protected]>
provokateurin
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.