Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not convert union types to string #37

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix: Do not convert union types to string #37

merged 2 commits into from
Dec 6, 2023

Conversation

provokateurin
Copy link
Member

Fixes #36

Merging the enums is necessary because otherwise every sub type of the union type will be it's own enum with only one possible value.

@provokateurin provokateurin mentioned this pull request Dec 6, 2023
Closed
2 tasks
nickvergessen
nickvergessen approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in #31 and talk

@nickvergessen nickvergessen merged commit 0060ce4 into main Dec 6, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix/union-parameters branch December 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Union parameters are always converted to string
2 participants
@provokateurin @nickvergessen