Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ControllerMethod): Add documentation for CORS endpoints #203

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat(ControllerMethod): Add documentation for CORS endpoints #203

merged 1 commit into from
Jan 7, 2025

Conversation

provokateurin
Copy link
Member

For #151

come-nc
come-nc approved these changes Jan 7, 2025
View reviewed changes
Copy link

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment in https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Http/Attribute/CORS.php#L15 really confused me. It seems it’s just copy/paste from PublicPage attribute.

@nickvergessen
Copy link
Member

It seems it’s just copy/paste from PublicPage attribute.

Yes, should fix 🙈

@provokateurin provokateurin merged commit 86a07bf into main Jan 7, 2025
12 of 18 checks passed
@provokateurin provokateurin deleted the feat/controllermethod/cors-documentation branch January 7, 2025 12:39
@provokateurin provokateurin mentioned this pull request Jan 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @nickvergessen @come-nc