Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generate-spec): Ignore index.php routes by default #192

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

provokateurin
Copy link
Member

index.php routes are not meant to be used for stable APIs.
Unfortunately we have a lot of legacy APIs that still use them so we can't just ignore them entirely.
This changes the default behavior to ignore them, but one can still manually include them by changing the scope for a method or controller.

@provokateurin provokateurin changed the title fix(generate-spec): Add fallback scopes before checking ignores feat(generate-spec): Ignore index.php routes by default Dec 17, 2024
@come-nc
Copy link

come-nc commented Dec 17, 2024

This might be a big breaker in server and apps, no?

@provokateurin
Copy link
Member Author

Not really breaking, you just need to add the default scopes to all routes you want to keep. I already have all the changes for that for server. I think most apps are luckily not using index.php routes.

@provokateurin provokateurin force-pushed the feat/generate-spec/ignore-index-routes-by-default branch from 633d05d to 492cfc7 Compare December 17, 2024 16:32
@provokateurin provokateurin merged commit c0761cb into main Dec 17, 2024
9 of 15 checks passed
@provokateurin provokateurin deleted the feat/generate-spec/ignore-index-routes-by-default branch December 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants