Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenApiType): Forbid using ambigous array syntaxes #168

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

provokateurin
Copy link
Member

Fixes #33

@provokateurin provokateurin changed the title fix: Provide more context when parsing response definitions fix(OpenApiType): Forbid using ambigous array syntaxes Sep 26, 2024
@provokateurin
Copy link
Member Author

Server and notifications are green now, shall we merge and make a new release @nickvergessen?

@nickvergessen
Copy link
Member

/me stares at 140 complains for empty arrays in talk

"Sure, let's go ahead"

@nickvergessen
Copy link
Member

nickvergessen commented Nov 6, 2024

Maybe array<empty> can be handled as an exception and only yield a warning?

@provokateurin
Copy link
Member Author

Maybe array can be handled as an exception and only yield a warning?

Could be added, but it's also very simple to fix with search and replace and there are no manual changes that need to be done.

@provokateurin provokateurin merged commit d7c135e into main Nov 6, 2024
9 of 14 checks passed
@provokateurin provokateurin deleted the fix/openapitype/array-syntax-ambiguities branch November 6, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest list<TYPE> over array<TYPE> and TYPE[]
3 participants