fix(OpenApiType): Use anyOf instead of oneOf for conflicting types #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current assumption that a union type is equivalent to oneOf is not correct.
The PHP type annotation
would mean the JSON would always be either
or
The OpenAPI spec mandates that exactly ONE schema matches the data. No more no less.
Our generated spec would look like
The first schema would always match both possibilities (additional properties are always allowed and ignored), so the assumption that only one schema ever matches is not true.
We don't want to use anyOf all the time though, because it makes some cases harder e.g. when you have
string|int
because here the assumption is correct.