fix(type): Only allow specified boolean when given

Signed-off-by: Joas Schilling <[email protected]>
nextcloud · Jan 8, 2024 · defa2d1 · defa2d1
1 parent a6dc75d
commit defa2d1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/OpenApiType.php b/src/OpenApiType.php
@@ -307,7 +307,9 @@ private static function resolveIdentifier(string $context, array $definitions, s
 			"positive-int" => new OpenApiType(type: "integer", format: "int64", minimum: 1),
 			"negative-int" => new OpenApiType(type: "integer", format: "int64", maximum: -1),
 			"non-positive-int" => new OpenApiType(type: "integer", format: "int64", maximum: 0),
-			"bool", "boolean", "true", "false" => new OpenApiType(type: "boolean"),
+			"bool", "boolean" => new OpenApiType(type: "boolean"),
+			"true" => new OpenApiType(type: "boolean", enum: [true]),
+			"false" => new OpenApiType(type: "boolean", enum: [false]),
 			"double" => new OpenApiType(type: "number", format: "double"),
 			"float" => new OpenApiType(type: "number", format: "float"),
 			"mixed", "empty", "array" => new OpenApiType(type: "object"),

diff --git a/tests/openapi.json b/tests/openapi.json
@@ -1297,9 +1297,6 @@
                         "required": true,
                         "schema": {
                             "oneOf": [
-                                {
-                                    "type": "boolean"
-                                },
                                 {
                                     "type": "integer",
                                     "enum": [
@@ -1313,6 +1310,12 @@
                                         "yes",
                                         "no"
                                     ]
+                                },
+                                {
+                                    "type": "boolean",
+                                    "enum": [
+                                        true
+                                    ]
                                 }
                             ]
                         }