feat(generate-spec): Disallow unused route requirements

Signed-off-by: provokateurin <[email protected]>
nextcloud · Dec 17, 2024 · 823a8b6 · 823a8b6
1 parent 63bbc54
commit 823a8b6
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/generate-spec.php b/generate-spec.php
@@ -587,6 +587,11 @@
 		preg_match_all('/{[^}]*}/', $route->url, $urlParameters);
 		$urlParameters = array_map(fn (string $name): string => substr($name, 1, -1), $urlParameters[0]);
 
+		$unusedRequirements = array_diff(array_keys($route->requirements), $urlParameters);
+		if ($unusedRequirements !== []) {
+			Logger::error($route->name, 'Unused requirements: ' . implode(',', $unusedRequirements));
+		}
+
 		foreach ($urlParameters as $urlParameter) {
 			$matchingParameters = array_filter($route->controllerMethod->parameters, fn (ControllerMethodParameter $param): bool => $param->name == $urlParameter);
 			$requirement = $route->requirements[$urlParameter] ?? null;