-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextcloud)!: Move all query parameters to body to fix many serialization problems #2129
Conversation
34d55e1
to
a0f3ecf
Compare
CI failure is due to the bloc tests not being migrated. |
a0f3ecf
to
d080089
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
- Coverage 30.73% 29.59% -1.14%
==========================================
Files 259 260 +1
Lines 85163 95000 +9837
==========================================
+ Hits 26174 28115 +1941
- Misses 58989 66885 +7896
*This pull request uses carry forward flags. Click here to find out more.
|
d080089
to
d734922
Compare
Ready for review, openapi-extractor PR was merged 🚀 |
d734922
to
64cedb2
Compare
05ab259
to
db36e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing really against this. I'm not a big fan of the double __
but this can later be changed in a non breaking update.
Approving to not block this further
packages/dynamite/dynamite_end_to_end_test/lib/request_body.openapi.dart
Outdated
Show resolved
Hide resolved
…st body Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…ization problems Signed-off-by: provokateurin <[email protected]>
db36e48
to
d2787bf
Compare
Depends on nextcloud/openapi-extractor#105
I can't even begin to list all the problems this solves 😅
There were quite some bugs in the way we serialized and encoded request bodies and how we handle default values in those cases. I wasn't really able to separate the fixes, so I hope this is ok.
We can also already merge the dynamite fixes and stash the nextcloud changes until the openapi-extractor PR is merged (which could be very soon already as there is only one minor blocker with the ocs_api_viewer).