Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamite): support all default value types #1983

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

Leptopoda
Copy link
Member

I've tested it with nextcloud/openapi-extractor#105 and it works fine.
At least the generated code does not have any errors and looks god.

@Leptopoda Leptopoda requested a review from provokateurin April 27, 2024 06:49
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 4.92308% with 309 lines in your changes are missing coverage. Please review.

Project coverage is 28.33%. Comparing base (f0b5f8a) to head (214a23a).
Report is 5 commits behind head on main.

❗ Current head 214a23a differs from pull request most recent head b3124a5. Consider uploading reports for the commit b3124a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   28.43%   28.33%   -0.10%     
==========================================
  Files         245      246       +1     
  Lines       81449    81754     +305     
==========================================
+ Hits        23161    23169       +8     
- Misses      58288    58585     +297     
Flag Coverage Δ *Carryforward flag
dynamite 22.63% <22.72%> (-0.09%) ⬇️
dynamite_end_to_end_test 57.76% <3.63%> (-4.87%) ⬇️
dynamite_runtime 82.65% <ø> (ø) Carriedforward from f0b5f8a
neon_dashboard 92.56% <ø> (ø)
neon_framework 38.36% <ø> (ø)
neon_talk 96.67% <ø> (ø)
nextcloud 25.69% <ø> (-0.01%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from f0b5f8a

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...e/dynamite_end_to_end_test/lib/all_of.openapi.dart 88.88% <100.00%> (+0.13%) ⬆️
...e/dynamite_end_to_end_test/lib/any_of.openapi.dart 70.43% <ø> (ø)
...te_end_to_end_test/lib/authentication.openapi.dart 91.37% <ø> (ø)
...ite/dynamite_end_to_end_test/lib/enum.openapi.dart 85.00% <ø> (ø)
...namite_end_to_end_test/lib/interfaces.openapi.dart 70.00% <ø> (ø)
...namite_end_to_end_test/lib/nested_ofs.openapi.dart 68.96% <100.00%> (+0.30%) ⬆️
...e/dynamite_end_to_end_test/lib/one_of.openapi.dart 62.36% <ø> (ø)
...ite_end_to_end_test/lib/pattern_check.openapi.dart 90.62% <ø> (ø)
...mite_end_to_end_test/lib/request_body.openapi.dart 85.29% <ø> (ø)
.../dynamite_end_to_end_test/lib/some_of.openapi.dart 36.36% <ø> (ø)
... and 21 more

@Leptopoda Leptopoda force-pushed the fix/dynamite/default_values branch from 214a23a to a970db4 Compare April 27, 2024 07:39
@Leptopoda Leptopoda requested a review from provokateurin April 27, 2024 07:39
@Leptopoda Leptopoda force-pushed the fix/dynamite/default_values branch from a970db4 to 2542c6e Compare April 27, 2024 07:44
@Leptopoda Leptopoda enabled auto-merge April 27, 2024 07:46
@Leptopoda Leptopoda force-pushed the fix/dynamite/default_values branch from 2542c6e to b3124a5 Compare April 27, 2024 08:09
@Leptopoda Leptopoda merged commit 6d2f62b into main Apr 27, 2024
8 checks passed
@Leptopoda Leptopoda deleted the fix/dynamite/default_values branch April 27, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants