-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamite): support all default value types #1983
Conversation
Signed-off-by: Nikolas Rimikis <[email protected]>
…s` lint rule Signed-off-by: Nikolas Rimikis <[email protected]>
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.dart
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
Outdated
Show resolved
Hide resolved
packages/dynamite/dynamite_end_to_end_test/lib/parameters.openapi.json
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 28.43% 28.33% -0.10%
==========================================
Files 245 246 +1
Lines 81449 81754 +305
==========================================
+ Hits 23161 23169 +8
- Misses 58288 58585 +297
*This pull request uses carry forward flags. Click here to find out more.
|
214a23a
to
a970db4
Compare
packages/dynamite/dynamite/lib/src/models/openapi/parameter.dart
Outdated
Show resolved
Hide resolved
a970db4
to
2542c6e
Compare
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
2542c6e
to
b3124a5
Compare
I've tested it with nextcloud/openapi-extractor#105 and it works fine.
At least the generated code does not have any errors and looks god.