Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): only install headless shell chromium for playwright #2544

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

max-nextcloud
Copy link
Contributor

@max-nextcloud max-nextcloud commented Feb 4, 2025

Speeds up the installation of the browsers drastically:

scenario 1st run 2nd run 3rd run avg
all browsers 53 sec 74 sec 59 sec ~ 62 sec
only chromium --with-deps 42 sec 29 sec 31 sec ~ 34 sec
chromium --with-deps --only-shell 22 sec 18 sec ~ 20 sec
chromium --only-shell 4 sec 5 sec ~ 4.5 sec

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.40%. Comparing base (929a649) to head (b9d7c35).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2544   +/-   ##
=========================================
  Coverage     43.40%   43.40%           
  Complexity      882      882           
=========================================
  Files            77       77           
  Lines          3359     3359           
=========================================
  Hits           1458     1458           
  Misses         1901     1901           

@max-nextcloud max-nextcloud force-pushed the test/speed-up-playwright-ci branch 3 times, most recently from 79414b3 to 6e6633f Compare February 4, 2025 21:17
@max-nextcloud max-nextcloud force-pushed the test/speed-up-playwright-ci branch from 6e6633f to b9d7c35 Compare February 4, 2025 21:25
@max-nextcloud max-nextcloud changed the title test(ci): only install chromium for playwright test(ci): only install headless shell chromium for playwright Feb 4, 2025
@max-nextcloud max-nextcloud marked this pull request as ready for review February 4, 2025 21:38
@max-nextcloud max-nextcloud requested a review from susnux February 4, 2025 21:38
@Chartman123 Chartman123 merged commit eddfae4 into main Feb 4, 2025
55 checks passed
@Chartman123 Chartman123 deleted the test/speed-up-playwright-ci branch February 4, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants