Fix: Show sidebar toggle in all views #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chartman123
added
bug
Chartman123
force-pushed
the
fix/2531-sidebar-toggle
branch
3 times, most recently
from
d8e3cd4 to
14b460e
Compare
Chartman123
added
3. to review
Chartman123
force-pushed
the
fix/2531-sidebar-toggle
branch
2 times, most recently
from
9f641fc to
84992cf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Chartman123
force-pushed
the
fix/2531-sidebar-toggle
branch
from
d94dfc9 to
40d277e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Chartman123
force-pushed
the
fix/2531-sidebar-toggle
branch
from
6f20813 to
e9b6b31
Compare
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
fix/2531-sidebar-toggle
branch
from
e9b6b31 to
425ba29
Compare
|
/backport to stable4 |
susnux
reviewed
Jan 31, 2025
susnux
approved these changes
Jan 31, 2025
They are only set in the frontend, not in the backend. We could do a refactoring as a follow up to move the submissions from this.form to just this.submissions :) |
2 tasks
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2531 by loading the full form in the results view in beforeMount()
To clean up the code and also remove a double loading of the full form, the check for a linked file has been refactored.
Signed-off-by: Christian Hartmann [email protected]