-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug. Question type File. When multiple types are selected, only one is used. #2241
Bug. Question type File. When multiple types are selected, only one is used. #2241
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
============================================
+ Coverage 46.03% 46.34% +0.30%
+ Complexity 800 799 -1
============================================
Files 66 66
Lines 3065 3064 -1
============================================
+ Hits 1411 1420 +9
+ Misses 1654 1644 -10 |
bab5f90
to
3d7dffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments after reviewing the code, will test it later :)
3d7dffc
to
bd49e13
Compare
Signed-off-by: ailkiv <[email protected]>
bd49e13
to
e98906d
Compare
@AIlkiv would you like to join our Forms team on cloud.nextcloud.com? If yes, I could help you get an account there as well... |
@Chartman123 Yes. Please help me with that. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
At each iteration, $question['accept'] is overwritten