-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add support for adding new entries with IME input #2232
Conversation
86bab53
to
0aa738a
Compare
6a78935
to
cab1f12
Compare
@susnux any idea why watching isComposing now changes the behaviour from posting the first entered character to now posting an empty option and then trying to update it which then of course fails? For testing you could try to enter an é or â or something like that... Update: Update 2: |
cab1f12
to
c990813
Compare
c990813
to
c1a74a9
Compare
@Chartman123 From mdn it seems that the input event is not guaranteed to be fired after composition ended but only on character input.
|
cacbed8
to
a08179b
Compare
17ab27d
to
a69944f
Compare
Duplicate code moved to `QuestionMixin.js`. The code changes in allow for adding new entries with IME input, specifically for languages like Japanese or Chinese. This improvement ensures a better user experience when using IME input methods. Signed-off-by: GitHub <[email protected]> Signed-off-by: Christian Hartmann <[email protected]>
a69944f
to
d6433f3
Compare
Seems to work, but i find testing a bit hard |
Yeah, let's see what our users will say with the next release :) |
This fixes #2220 by checking for isComposing state of the InputEvent
Duplicate code moved to
QuestionMixin.js
. The code changes allow for adding new entries with IME input, specifically for languages like Japanese or Chinese. This improvement ensures a better user experience when using IME input methods.