-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of multi-columns descriptions #2201
Conversation
I am not sure about this, I do not see a good use case and will make thing more complex. Opinions @jancborchardt @Chartman123 ? |
Yeah same for me... another dependency for only a really small benefit. |
for our use case It has sense for students quizzes, e.g. we have some image/schema on the left column and a question on the right column |
a2cff14
to
535e017
Compare
Signed-off-by: Konstantin Myakshin <[email protected]>
535e017
to
bb18466
Compare
Updates:
|
@Koc thanks for the updated description with the preview... How would this work together with your other PR to implement Text as a Markdown editor? As far as I could see Text doesn't support multi-columns. |
@Chartman123 I've plan to close #2164 because it requires much more work than I expected for adding images support. So there are no any conflicts with this 2 PRs anymore 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Text doesn’t support multi-columns, I am also hesitant to add this. As mentioned, we shouldn’t stray too much from a standard, and at least be internally consistent.
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@Koc you can follow the blocklist link in the last post to add your username to the list so that your PRs don't get this feedback post :) |
Now we can use multi-columns descriptions thankful to markdown-it-container plugin
🔍 Preview