-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source for the Analytics App #2195
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
============================================
- Coverage 45.95% 45.17% -0.79%
- Complexity 797 811 +14
============================================
Files 65 67 +2
Lines 3066 3119 +53
============================================
Hits 1409 1409
- Misses 1657 1710 +53 |
CI is failing a lot (PHP code style, missing stubs for psalm, missing unit tests), please fix this :) Also cc @Chartman123, what do you think about this? |
@susnux if this doesn't come with any problems when the Analytics app isn't installed, I'd be fine with it. |
@Chartman123 I just did another test on my side - all clean. no nextcloud.log ...we only need to find a way for the psalm and the unit-tests... |
41fa849
to
2f4feae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look okay.
@Rello are you ready with this PR? Perhaps you could add some more unit tests, so that the Codecov workflows turn green, too 🙂 Before we merge this, also please do a rebase on current main and squash all the commits into one single commit. |
Hi @Chartman123 |
@Rello please don't merge the main branch into your branch and use |
Hi, |
Rebasing results in a cleaner commit history, when we merge the changes back into our main :) |
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: F. E Noel Nfebe <[email protected]> Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
@Chartman123 @susnux |
Signed-off-by: Christian Hartmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
🙏🏻 |
@susnux we should have squashed the commits into one single commit first... ;) |
This pull adds a data source to report on forms with Analyitcs
Data source selection
Single report
Dashboard