Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data source for the Analytics App #2195

Merged
merged 24 commits into from
Jul 29, 2024
Merged

Data source for the Analytics App #2195

merged 24 commits into from
Jul 29, 2024

Conversation

Rello
Copy link
Contributor

@Rello Rello commented Jun 1, 2024

This pull adds a data source to report on forms with Analyitcs

  • real time reporting
  • scheduled data loads (for trends)
  • charts and/or tables
  • multi page dashboards (coming with Analytics 5)
  • PDF/print dashboards (coming with Analytics 5)
  • one-click dashboard creation for all questions of a form

Data source selection

Bildschirmfoto 2024-06-01 um 17 43 25


Single report

Bildschirmfoto 2024-06-01 um 17 46 31


Dashboard

Bildschirmfoto 2024-06-01 um 17 48 57

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 45.17%. Comparing base (e019081) to head (0530cd1).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2195      +/-   ##
============================================
- Coverage     45.95%   45.17%   -0.79%     
- Complexity      797      811      +14     
============================================
  Files            65       67       +2     
  Lines          3066     3119      +53     
============================================
  Hits           1409     1409              
- Misses         1657     1710      +53     

@susnux
Copy link
Collaborator

susnux commented Jun 1, 2024

CI is failing a lot (PHP code style, missing stubs for psalm, missing unit tests), please fix this :)

Also cc @Chartman123, what do you think about this?

@Chartman123
Copy link
Collaborator

@susnux if this doesn't come with any problems when the Analytics app isn't installed, I'd be fine with it.

@Rello
Copy link
Contributor Author

Rello commented Jun 4, 2024

@Chartman123 I just did another test on my side - all clean. no nextcloud.log
happy for an other retest

...we only need to find a way for the psalm and the unit-tests...

@susnux susnux force-pushed the Rello-Analytics branch 2 times, most recently from 41fa849 to 2f4feae Compare June 12, 2024 21:25
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look okay.

psalm.xml Outdated Show resolved Hide resolved
@susnux susnux force-pushed the Rello-Analytics branch from 2f4feae to 0243763 Compare June 13, 2024 10:03
@Chartman123
Copy link
Collaborator

@Rello are you ready with this PR? Perhaps you could add some more unit tests, so that the Codecov workflows turn green, too 🙂

Before we merge this, also please do a rebase on current main and squash all the commits into one single commit.

@Rello
Copy link
Contributor Author

Rello commented Jun 24, 2024

Hi @Chartman123
I will retest one more time and post an update here.
regarding unit tests, I would need assistant. I never did these in the past as the dev-capacity is pretty limited...

@Chartman123
Copy link
Collaborator

@Rello please don't merge the main branch into your branch and use git rebase instead :)

@Rello
Copy link
Contributor Author

Rello commented Jun 25, 2024

@Rello please don't merge the main branch into your branch and use git rebase instead :)

Hi,
any hint on the background? I was always doing this until now. but open to learn something better.
Tx!

@Chartman123
Copy link
Collaborator

Rebasing results in a cleaner commit history, when we merge the changes back into our main :)

@Rello Rello force-pushed the Rello-Analytics branch from ad2db9b to 8b3c18e Compare July 3, 2024 11:38
@Rello
Copy link
Contributor Author

Rello commented Jul 3, 2024

@Chartman123 @susnux
all tests are green - besides the codecov part and I have no idea how to solve this.
what do you suggest to do here?

Signed-off-by: Christian Hartmann <[email protected]>
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

lib/Analytics/AnalyticsDatasource.php Outdated Show resolved Hide resolved
@susnux susnux merged commit 71b3185 into main Jul 29, 2024
49 of 51 checks passed
@susnux susnux deleted the Rello-Analytics branch July 29, 2024 06:57
@Rello
Copy link
Contributor Author

Rello commented Jul 29, 2024

🙏🏻

@Chartman123
Copy link
Collaborator

@susnux we should have squashed the commits into one single commit first... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants