Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use prettier for stylistic rules #2143

Merged
merged 3 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,23 @@
"appName": true
},
"extends": [
"@nextcloud"
"@nextcloud",
"prettier" // < this needs to be the last one to override all previous
],
"rules": {
// We are using the @nextcloud/logger
"no-console": "error",
"import/no-unresolved": ["error", { "ignore": ["\\?raw"] }]
}
},
"overrides": [
{
"files": ["**/*.vue"],
"rules": {
"vue/first-attribute-linebreak": [
"error",
{ "multiline": "below", "singleline": "ignore" }
]
}
}
]
}
44 changes: 27 additions & 17 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ about: Create a report to help us improve
title: ''
labels: 0. Needs triage, bug
assignees: ''

---

**Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!**

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -25,21 +26,25 @@ A clear and concise description of what you expected to happen.
If applicable, add screenshots to help explain your problem.

**Nextcloud (please complete the following information):**
- Nextcloud-Version: [e.g. 19.0.0]
- Forms-Version: [e.g. 2.0.0-beta4]

- Nextcloud-Version: [e.g. 19.0.0]
- Forms-Version: [e.g. 2.0.0-beta4]

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

**Browser log**

```
Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.
```
Expand All @@ -48,29 +53,34 @@ Open your console, reload your page and/or do the action leading to this issue a
<summary>How to access your browser console (Click to expand)</summary>

# Chrome
- Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
- Alternative method:

- Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
- Alternative method:
1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
2. Click the “console” tab.

# Safari
- Press CMD + ALT + I to open the Web Inspector.
- See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

- Press CMD + ALT + I to open the Web Inspector.
- See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

# IE9

1. Press F12 to open the developer tools.
2. Click the “console” tab.

# Firefox
- Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
- or, if Firebug is installed (recommended):

- Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
- or, if Firebug is installed (recommended):
1. Press F12 to open Firebug.
2. Click on the “console” tab.

# Opera

1. Press CTRL + SHIFT + I to open Dragonfly.
2. Click on the “console” tab.
</details>
</details>

**Additional context**
Add any other context about the problem here.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ about: Suggest an idea for this project
title: ''
labels: 0. Needs triage, enhancement
assignees: ''

---

**Nextcloud (please complete the following information):**
- Nextcloud-Version: [e.g. 19.0.0]
- Forms-Version: [e.g. 2.0.0-beta4]

- Nextcloud-Version: [e.g. 19.0.0]
- Forms-Version: [e.g. 2.0.0-beta4]

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Expand Down
194 changes: 97 additions & 97 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,106 +1,106 @@
version: 2
updates:
- package-ecosystem: composer
target-branch: "main"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: composer
target-branch: 'main'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: composer
target-branch: "main"
directory: "/vendor-bin/cs-fixer/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: composer
target-branch: 'main'
directory: '/vendor-bin/cs-fixer/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: npm
target-branch: "main"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: npm
target-branch: 'main'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: github-actions
target-branch: "main"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: github-actions
target-branch: 'main'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

# Update stable3 until NC27 is out of support
- package-ecosystem: composer
target-branch: "stable3"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
# Update stable3 until NC27 is out of support
- package-ecosystem: composer
target-branch: 'stable3'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: composer
target-branch: "stable3"
directory: "/vendor-bin/cs-fixer/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: composer
target-branch: 'stable3'
directory: '/vendor-bin/cs-fixer/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: npm
target-branch: "stable3"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: npm
target-branch: 'stable3'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies

- package-ecosystem: github-actions
target-branch: "stable3"
directory: "/"
schedule:
interval: weekly
day: saturday
time: "03:00"
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
- package-ecosystem: github-actions
target-branch: 'stable3'
directory: '/'
schedule:
interval: weekly
day: saturday
time: '03:00'
timezone: Europe/Paris
open-pull-requests-limit: 10
labels:
- 3. to review
- dependencies
4 changes: 2 additions & 2 deletions .github/pr-feedback.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
days-before-feedback: 14
start-date: "2023-07-10"
exempt-authors: "${{ steps.scrape.outputs.users }}"
start-date: '2023-07-10'
exempt-authors: '${{ steps.scrape.outputs.users }}'
exempt-bots: true
4 changes: 2 additions & 2 deletions .github/workflows/appstore-build-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: skjnldsv/xpath-action@7e6a7c379d0e9abc8acaef43df403ab4fc4f770c # master
with:
filename: ${{ env.APP_NAME }}/appinfo/info.xml
expression: "//info//dependencies//nextcloud/@min-version"
expression: '//info//dependencies//nextcloud/@min-version'

- name: Read package.json node and npm engines version
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
id: check_composer
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2
with:
files: "${{ env.APP_NAME }}/composer.json"
files: '${{ env.APP_NAME }}/composer.json'

- name: Install composer dependencies
if: steps.check_composer.outputs.files_exists == 'true'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
id: check_composer
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2
with:
files: "composer.json"
files: 'composer.json'

- name: Install composer dependencies
if: steps.check_composer.outputs.files_exists == 'true'
Expand All @@ -44,8 +44,8 @@ jobs:
uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
id: versions
with:
fallbackNode: "^20"
fallbackNpm: "^10"
fallbackNode: '^20'
fallbackNpm: '^10'

- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
Expand Down
Loading
Loading