fix: add icon to title of required questions in edit mode

[Chartman123]

This fixes #2098 by adding a visual indicator in edit mode that a question is required:

(Also removes some now obsolete conditions)

Signed-off-by: Christian Hartmann [email protected]

[Chartman123]

/backport to stable4

[jancborchardt]

The icon technically is an asterisk, but it does look a bit funky and unexpected.

What do you think instead about a little red circle overlaid on the 3-dot menu (much like when you have unread notifications), which calls attention to opening the menu which then also explains that it is required?

Then we also save 1 icon spot additionally.

[Chartman123]

What do you think instead about a little red circle overlaid on the 3-dot menu (much like when you have unread notifications), which calls attention to opening the menu which then also explains that it is required?

@jancborchardt thanks for the review. I think if we want to point out directly that one of settings of the submenu is enabled, it should be directly visible. Otherwise you wouldn't know what the red ring means and you'd have to look into the menu.

But I'm with you that it is probably a little bit too big...

[susnux]

Maybe just add it to the placeholder?
So instead of "People can enter a number" -> "People can enter a number (required)" or similar?

[Chartman123]

For text questions ok, but how would you do it for e.g. the new file question?

[jotoeri]

Was just dropping by so here some greets and my 5 cent:
I like the mark on the three dot menu - but i'd think about using an asterisk there. This should be clearly connected to the required option. I could imagine one could do that similarly with specific signs of up to three options from the menu (or maybe even four on the four edges)? 😉

👋

[susnux]

I like the mark on the three dot menu - but i'd think about using an asterisk there.

I like the idea 👍

[Chartman123]

So we overlay the Icon in small over the three dot menu?

[susnux]

Would look like this:

Or:

---

Feel free to drop the commit.

[Chartman123]

I could live with that, but move it to the top left and don't use the red color. I think this is too much.

[susnux]

or

[Chartman123]

Thanks for updating the screenshots and the code :) I only have little time right now...

I'd be fine with that second version without the accent color :) @jancborchardt what do you think?

[jancborchardt]

Yep, agree with @Chartman123 , second version without the accent is very nice. :) Thanks @susnux as well!