fix(Submit): Make answers reactive and fix invalid mutation of computed property
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/local-storage-handling
branch
from
a986a8b to
4273340
Compare
|
Works also with "other" answer: v.mp4 |
Chartman123
reviewed
Nov 21, 2023
Chartman123
reviewed
Nov 21, 2023
susnux
force-pushed
the
fix/local-storage-handling
branch
from
ed3b3ab to
31007d4
Compare
susnux
force-pushed
the
fix/local-storage-handling
branch
from
31007d4 to
842b521
Compare
|
Fixed the "other" answer cache, see: vokoscreenNG-2023-11-22_17-01-24.mp4 |
susnux
force-pushed
the
fix/local-storage-handling
branch
from
842b521 to
13e090f
Compare
Chartman123
reviewed
Nov 22, 2023
susnux
force-pushed
the
fix/local-storage-handling
branch
from
13e090f to
02184d3
Compare
…uted property Setting `answers` using `.sync` is not reactive as property changes are not triggering the computed / watch effect, so instead use a `onUpdate` method to update the `answers` object in a way that will trigger any watch effect. Also make `getFormValuesFromLocalStorage` a method instead a computed value. Previously that computed value were assigned a new value which is invalid as computed values should be constant (except for computed setter but this was none). And make sure "other" answer is set correctly so it will be saved in LocalStorage Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/local-storage-handling
branch
from
02184d3 to
24cfb5d
Compare
… add the cached text to the option Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/local-storage-handling
branch
from
24cfb5d to
eb7ced6
Compare
Chartman123
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the root cause for the question component not updating: Non reactive answers in
Submit, meaning after assigning a new value toanswers[key]the watch effect was never triggered and thus the question component was never updated.So instead use a
onUpdatemethod to update theanswersobject in a way that will trigger any watch effect.Also make
getFormValuesFromLocalStoragea method instead a computed value. Previously that computed value were assigned a new value which is invalid as computed values should be constant (except for computed setter but this was none).