-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and examples update for use with docker compose v2 #2201
Open
tzerber
wants to merge
12
commits into
nextcloud:master
Choose a base branch
from
tzerber:compose-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a87a922
Update examples section according to the latest docker compose requir…
tzerber 42a6bec
Minor readme updates to match the changes for the compose v2 syntax.
tzerber 97e152a
Fix wrong environment variable
tzerber c578809
Add missing headers to fpm config
tzerber eb6431c
Fix cache control
tzerber 05353cf
Add mjs file extension in a proper way.
tzerber d1fad61
Typos fixed, minor clarification changes
tzerber 3f4a8d4
Removed logging from compose files.
tzerber b4b5f3c
Restored MariaDB to 10.6 as per docs suggestions
tzerber f1e8bef
Remove extra nginx volume
tzerber 9c714c7
Removed GH specific markdown from Readme, change mariadb to recommend…
tzerber 42d0652
typo
tzerber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 0 additions & 2 deletions
2
...nsecure/mariadb/apache/docker-compose.yml → ...pose/insecure/mariadb/apache/compose.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
version: '3' | ||
|
||
services: | ||
db: | ||
image: mariadb:10.6 | ||
|
2 changes: 0 additions & 2 deletions
2
...e/insecure/mariadb/fpm/docker-compose.yml → ...compose/insecure/mariadb/fpm/compose.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
version: '3' | ||
|
||
services: | ||
db: | ||
image: mariadb:10.6 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
.../insecure/postgres/fpm/docker-compose.yml → ...ompose/insecure/postgres/fpm/compose.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,3 @@ | ||||||
version: '3' | ||||||
|
||||||
services: | ||||||
db: | ||||||
image: postgres:alpine | ||||||
|
@@ -29,6 +27,7 @@ services: | |||||
depends_on: | ||||||
- db | ||||||
- redis | ||||||
- proxy | ||||||
networks: | ||||||
- proxy-tier | ||||||
- default | ||||||
|
@@ -50,9 +49,9 @@ services: | |||||
- 80:80 | ||||||
- 443:443 | ||||||
labels: | ||||||
com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy: "true" | ||||||
- "com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy" | ||||||
volumes: | ||||||
- certs:/etc/nginx/certs:z,ro | ||||||
- certs:/etc/nginx/certs:ro:z | ||||||
- vhost.d:/etc/nginx/vhost.d:z | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- html:/usr/share/nginx/html:z | ||||||
- /var/run/docker.sock:/tmp/docker.sock:z,ro | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those
:ro:z
are still wrong