-
Notifications
You must be signed in to change notification settings - Fork 102
Allow selecting recipes with unassigned category #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting recipes with unassigned category #362
Conversation
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
d4f2bd9
to
e0d7550
Compare
Signed-off-by: Sebastian Fey <[email protected]>
e0d7550
to
bc4b8d4
Compare
I just had a quick look at the changes. In fact I have a bit of a bad feeling here. Apart from the fact that using an arbitrary symbol as a special value for no category, I found these lines: [1], [2]. These are using a star as symbol (neither really good). I have to admit, that I have not yet tested the changes. My suggestion is to stick with either symbol (makes no difference to me). Then in #332, #299 and #365 there is the chance to define a more stable API. Any comments/suggestions on that by anyone? |
I have seen the Obviously this would conflict with a category named “_”, so a new API endpoint might be helpful. I didn’t want to start on this as @christianlupus was discussing API changes somewhere else, anyway, if I remember correctly. |
You remember correctly, apart from #342 I was considering to do quite some backend refactory. If you do not mind that these changes are overwritten "soon", I'd test them and merge until the more thorough rework is finished. |
No that’s fine. I just thought it might be nice to have this option even "sooner" ;) And to close the corresponding issue. |
OK, a quick test shows that it seems to work so far. Will merge that and hope for the best. 😄 |
Added item for viewing uncategorized recipes in the navigation.
Closes #326