Skip to content

Allow selecting recipes with unassigned category #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Oct 29, 2020

Added item for viewing uncategorized recipes in the navigation.

Closes #326

@seyfeb seyfeb force-pushed the bugfix/showItemForRecipesWithUnassignedCategory branch from d4f2bd9 to e0d7550 Compare October 29, 2020 19:50
@seyfeb seyfeb force-pushed the bugfix/showItemForRecipesWithUnassignedCategory branch from e0d7550 to bc4b8d4 Compare October 29, 2020 19:52
@christianlupus
Copy link
Collaborator

I just had a quick look at the changes. In fact I have a bit of a bad feeling here. Apart from the fact that using an arbitrary symbol as a special value for no category, I found these lines: [1], [2]. These are using a star as symbol (neither really good).

I have to admit, that I have not yet tested the changes.

My suggestion is to stick with either symbol (makes no difference to me). Then in #332, #299 and #365 there is the chance to define a more stable API. Any comments/suggestions on that by anyone?

@seyfeb
Copy link
Collaborator Author

seyfeb commented Oct 31, 2020

I have seen the * being used as well, but had the feeling using this would be even worse. I would rather interpret it as a wildcard, matching every category. I didn’t want to break anything else though, so I just used _ as a proposal.

Obviously this would conflict with a category named “_”, so a new API endpoint might be helpful. I didn’t want to start on this as @christianlupus was discussing API changes somewhere else, anyway, if I remember correctly.

@christianlupus
Copy link
Collaborator

christianlupus commented Oct 31, 2020

You remember correctly, apart from #342 I was considering to do quite some backend refactory. If you do not mind that these changes are overwritten "soon", I'd test them and merge until the more thorough rework is finished.

@seyfeb
Copy link
Collaborator Author

seyfeb commented Oct 31, 2020

No that’s fine. I just thought it might be nice to have this option even "sooner" ;) And to close the corresponding issue.

@christianlupus
Copy link
Collaborator

OK, a quick test shows that it seems to work so far. Will merge that and hope for the best. 😄

@christianlupus christianlupus merged commit 40e7699 into nextcloud:master Oct 31, 2020
@seyfeb seyfeb deleted the bugfix/showItemForRecipesWithUnassignedCategory branch November 4, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'None' category selection
2 participants